Hi,

I have some code that I am able to compile in the Arduino IDE but when I try and compile it in VS2010 it give me a compiling error. It started when I started implementing a structure.

These are the errors I get

Compiling 'funWithSounds' for 'Arduino Uno'
funWithSounds.ino : variable or field 'playBack' declared void
funWithSounds.ino : 'musicNote' was not declared in this scope
funWithSounds.ino : expected primary-expression before 'int'
Error compiling
 

This is the code associated with the sections in descending order.

This is the Definition of the Structure

struct musicNote
{
	char note;              //note
	unsigned int beat;      //length played
};

 

I used a function declaration at the beginning of the program

void playBack(musicNote note[], int arrySize);         //plays back contents in musicNote
 

This where I declared my musicNote variable

musicNote note[MAX];         //all notes are recorded to this structure
 

This is how the function is called.

playBack(note, tuneLen);
 

This is the definition of the function

void playBack(musicNote note[], int arrySize)
{
	for( int i = 0; i < arrySize; i++)
	{
		if (note[i].note == 'c')
			for (int j = 0; j < note[i].beat; j++)
				playNote(soundPin, 1915); 

		if (note[i].note == 'b')
			for (int j = 0; j < note[i].beat; j++)
				playNote(soundPin, 1700); 

		if (note[i].note == 'a')
			for (int j = 0; j < note[i].beat; j++)
				playNote(soundPin, 1519);
		if (note[i].note == '.')
		{
			sensorValue = analogRead(sensorPin);
			Serial.print(sensorValue);
			Serial.print('\n');
			delay((note[i].beat)/(sensorValue + 50));
		}
	}
}
 

Before I added the structure the program compiled fine and uploaded to the Arduino with no issues. Thanks for any help.

TPBW4321

No it does not compile after commenting that section out. I sent the you the source

Tim@Visual Micro wrote on Dec 23^rd, 2012 at 7:46pm:

I have found the problem. You might know that normally the prototypes are automatically created and added to the top of the sketch (below any #includes).

In your case one of your prototypes (playBack), uses a struct (musicNote) that is also defined in the same sketch. So in this case, it doesn't make sense (is an error) to add prototypes to the top of your sketch.

I'll change vm in the next release to prevent it automatically adding prototypes if they already exist. It's something I have been meaning to do anyway and the more recent versions of the Arduino IDE do the same. This is why is works in arduino but not in VS.

There is an easy fix if it meets your needs. You can add a ".h" to your sketch project, #include it at the top of beatMaker.ino and  move the musicNote struct from the .ino to the .h

struct musicNote
{
	char note;              //note
	unsigned int beat;      //length played
};
 

The .h needs to reside in the same folder as the beatMaker.ino. 

The best way to add a .h is to right click the beatMaker project in the solution explorer and click "Add new item"

With this solution we also remove the need to create prototypes for all the methods in your code.

Example: I created a breatMaker.h and moved the struct to it. The compile then worked. I also tried commenting out all of your prototypes and the compile still worked. So you might consider this a more productive solution. See below...

#include "beatMaker.h"
#define MAX 500 

const int buttonPin = 2;     // the number of the pushbutton pin
const int ledPin =  13;      // the number of the LED pin
const int playBackPin = 8;
const int soundPin = 9;
const int dPin = 10;
const int ePin = 11;
const int recordPin = 12;
const int sensorPin = 1;

// variables will change:
int buttonState = 0;         //c
int buttonState2 = 0;        //d
int buttonState3 = 0;        //e
int buttonState4 = 0;        //record
int buttonState5 = 0;        //playBack
int recordState = 0;         //if recording
int sensorValue = 0;         //variable Resistor
int i = 0;
int tuneLen = 0;             //length of tune
int delayLen = 0;            //note play length
musicNote note[MAX];         //all notes are recorded to this structure

//void playBack(musicNote note[], int arrySize);         //plays back contents in musicNote
//void playNote(const int pin, int note);                //plays a single note
//void clearNotes();                                     //clears musicNote
//void readPins();                                       //reads all inputs
//int rec();

void setup() {